-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Variables page #972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Variables page #972
Conversation
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/primer/primer-css/ihjujkf9z |
|
I'm blocked on getting this to deploy because Gatsby doesn't seem to like importing (in JS) files outside of the project directory (in this case, But I'm very clearly importing |
|
If I don't get around to fixing this up by the end of the week, one thing to try might be copying the built files from |
|
💥 This works and is ready for review! Preview here: https://primer-css-git-variables-page.primer.now.sh/css/support/variables |
simurai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this. Will be super handy! 🎉
Left one comment about not repeating the "intro notes", otherwise LGTM! 👍
simurai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome.. ok, let's get this into #999. 🚀
|
Yay, thanks for getting this over the finish line, @BinaryMuse! ❤️ |
😭 No docs preview yet, sorry!
This builds on #971 and (after a bad first attempt a couple of weeks ago) adds a new Support / Variables page that looks like this:
And it incorporates the deprecation data to let people know that if/when they're going away!
TODO
@primer/cssindocs/package.jsonfor... what, exactly? 🤔